[Lldb-commits] [lldb] [LLDB][SBSaveCore] Implement a selectable threadlist for Core Options. (PR #100443)

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Wed Jul 24 20:44:43 PDT 2024


================
@@ -6608,8 +6608,9 @@ bool ObjectFileMachO::SaveCore(const lldb::ProcessSP &process_sp,
         mach_header.ncmds = segment_load_commands.size();
         mach_header.flags = 0;
         mach_header.reserved = 0;
-        ThreadList &thread_list = process_sp->GetThreadList();
-        const uint32_t num_threads = thread_list.GetSize();
+        std::vector<ThreadSP> thread_list =
+            process_sp->CalculateCoreFileThreadList(options);
+        const uint32_t num_threads = thread_list.size();
----------------
clayborg wrote:

remove this as before we needed to use the `ThreadList` class which didn't have an iterator. Now we have a `std::vector<ThreadSP>` so we can use the build in iteration. See below.

https://github.com/llvm/llvm-project/pull/100443


More information about the lldb-commits mailing list