[Lldb-commits] [lldb] [lldb/Plugins] Introduce Scripted Platform Plugin (PR #99814)

Med Ismail Bennani via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 22 20:52:07 PDT 2024


================
@@ -299,6 +301,35 @@ SBPlatform::SBPlatform(const char *platform_name) {
   m_opaque_sp = Platform::Create(platform_name);
 }
 
+SBPlatform::SBPlatform(const char *platform_name, const SBDebugger &debugger,
+                       const char *script_name, const SBStructuredData &dict)
+    : SBPlatform(platform_name) {
+  LLDB_INSTRUMENT_VA(this, platform_name, debugger, script_name, dict);
+
+  if (!m_opaque_sp)
+    return;
+
+  if (!script_name || !dict.IsValid() || !dict.m_impl_up)
----------------
medismailben wrote:

Actually, `SBStructuredData::IsValid` just calls `IsValid` on the `unique_ptr` without checking it before, which could lead to a crash. I'll fix that in a separate patch.

https://github.com/llvm/llvm-project/pull/99814


More information about the lldb-commits mailing list