[Lldb-commits] [lldb] Removed header and validated on new windows machine (PR #96724)

via lldb-commits lldb-commits at lists.llvm.org
Tue Jun 25 20:08:09 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Jacob Lalonde (Jlalond)

<details>
<summary>Changes</summary>

![image](https://github.com/llvm/llvm-project/assets/25160653/2044cc8e-72d5-49ec-9439-256555f5fd2b)

In #<!-- -->95312 uint and `#include <unistd.h>` were introduced. These broke the windows build. I addressed uint in #<!-- -->96564, but include went unfixed. So I acquired myself a windows machine to validate.

---
Full diff: https://github.com/llvm/llvm-project/pull/96724.diff


1 Files Affected:

- (modified) lldb/source/Plugins/ObjectFile/Minidump/ObjectFileMinidump.cpp (-1) 


``````````diff
diff --git a/lldb/source/Plugins/ObjectFile/Minidump/ObjectFileMinidump.cpp b/lldb/source/Plugins/ObjectFile/Minidump/ObjectFileMinidump.cpp
index 3668c37c5191d..7c875aa3223ed 100644
--- a/lldb/source/Plugins/ObjectFile/Minidump/ObjectFileMinidump.cpp
+++ b/lldb/source/Plugins/ObjectFile/Minidump/ObjectFileMinidump.cpp
@@ -18,7 +18,6 @@
 #include "lldb/Utility/Log.h"
 
 #include "llvm/Support/FileSystem.h"
-#include <unistd.h>
 
 using namespace lldb;
 using namespace lldb_private;

``````````

</details>


https://github.com/llvm/llvm-project/pull/96724


More information about the lldb-commits mailing list