[Lldb-commits] [lldb] Removed header and validated on new windows machine (PR #96724)

Jacob Lalonde via lldb-commits lldb-commits at lists.llvm.org
Tue Jun 25 20:07:39 PDT 2024


https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/96724

![image](https://github.com/llvm/llvm-project/assets/25160653/2044cc8e-72d5-49ec-9439-256555f5fd2b)

In #95312 uint and `#include <unistd.h>` were introduced. These broke the windows build. I addressed uint in #96564, but include went unfixed. So I acquired myself a windows machine to validate.

>From aa9c8fae63f9124c59332cbfd4e84e3e229b1956 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde <jalalonde at fb.com>
Date: Tue, 25 Jun 2024 20:04:13 -0700
Subject: [PATCH] Removed header and validated on new windows machine

---
 lldb/source/Plugins/ObjectFile/Minidump/ObjectFileMinidump.cpp | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lldb/source/Plugins/ObjectFile/Minidump/ObjectFileMinidump.cpp b/lldb/source/Plugins/ObjectFile/Minidump/ObjectFileMinidump.cpp
index 3668c37c5191d..7c875aa3223ed 100644
--- a/lldb/source/Plugins/ObjectFile/Minidump/ObjectFileMinidump.cpp
+++ b/lldb/source/Plugins/ObjectFile/Minidump/ObjectFileMinidump.cpp
@@ -18,7 +18,6 @@
 #include "lldb/Utility/Log.h"
 
 #include "llvm/Support/FileSystem.h"
-#include <unistd.h>
 
 using namespace lldb;
 using namespace lldb_private;



More information about the lldb-commits mailing list