[Lldb-commits] [lldb] Fix type lookup bug where wrong decl context was being used for a DIE. (PR #94846)

via lldb-commits lldb-commits at lists.llvm.org
Sat Jun 8 00:03:47 PDT 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {darker}-->


:warning: Python code formatter, darker found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
darker --check --diff -r 5aabbf0602c48b67bb89fd37f95bf97c95ded488...2f579ecafeaeb735cbce1bcfc829eb52a93f067c lldb/test/API/functionalities/type_types/TestFindTypes.py
``````````

</details>

<details>
<summary>
View the diff from darker here.
</summary>

``````````diff
--- TestFindTypes.py	2024-06-08 06:56:03.000000 +0000
+++ TestFindTypes.py	2024-06-08 07:03:23.715724 +0000
@@ -43,27 +43,27 @@
         for api in [target, exe_module]:
             # We should find the "a::Foo" but not the "Foo" type in the function
             types = api.FindTypes("a::Foo")
             self.assertEqual(types.GetSize(), 1)
             type_str0 = str(types.GetTypeAtIndex(0))
-            self.assertIn('struct Foo', type_str0)
+            self.assertIn("struct Foo", type_str0)
 
             # When we search by type basename, we should find any type whose
             # basename matches "Foo", so "a::Foo" and the "Foo" type in the
             # function.
             types = api.FindTypes("Foo")
             self.assertEqual(types.GetSize(), 2)
             type_str0 = str(types.GetTypeAtIndex(0))
             type_str1 = str(types.GetTypeAtIndex(1))
             # We don't know which order the types will come back as, so
-            if 'struct Foo' in type_str0:
-                self.assertIn('typedef Foo', type_str1)
+            if "struct Foo" in type_str0:
+                self.assertIn("typedef Foo", type_str1)
             else:
-                self.assertIn('struct Foo', type_str1)
+                self.assertIn("struct Foo", type_str1)
 
             # When we search by type basename with "::" prepended, we should
             # only types in the root namespace which means only "Foo" type in
             # the function.
             types = api.FindTypes("::Foo")
             self.assertEqual(types.GetSize(), 1)
             type_str0 = str(types.GetTypeAtIndex(0))
-            self.assertIn('typedef Foo', type_str0)
+            self.assertIn("typedef Foo", type_str0)

``````````

</details>


https://github.com/llvm/llvm-project/pull/94846


More information about the lldb-commits mailing list