[Lldb-commits] [lldb] [lldb-dap] Added "port" property to vscode "attach" command. (PR #91570)

[Greg Clayton via lldb-commits]

================
@@ -672,9 +672,14 @@ void request_attach(const llvm::json::Object &request) {
   lldb::SBError error;
   FillResponse(request, response);
   lldb::SBAttachInfo attach_info;
+  const int invalid_port = 0;
   auto arguments = request.getObject("arguments");
   const lldb::pid_t pid =
       GetUnsigned(arguments, "pid", LLDB_INVALID_PROCESS_ID);
+  const auto gdb_remote_port =
+      GetUnsigned(arguments, "gdb-remote-port", invalid_port);
+  llvm::StringRef gdb_remote_hostname =
+      GetString(arguments, "gdb-remote-hostname", "localhost");
----------------
clayborg wrote:

I know in the past we have used `127.0.0.1` instead of `localhost`. The reason is people can modify their config files in their environment and `localhost` can be aliased to something else. Not sure if this is an issue

https://github.com/llvm/llvm-project/pull/91570