[Lldb-commits] [lldb] [LLDB] [NFC] Fix a cppcheck warning in lldb/source/Utility/Scalar.cpp (PR #94775)

[Shivam Gupta via lldb-commits]

xgupta wrote:

> The change LGTM, but I have a few suggestions regarding the title and description:
> 
>     * Retitle the PR to something like "[lldb] Remove dead code block (NFC)" or something that conveys the intent/outcome. The modified file and line number are already part of the commit and are just redundant. You could mention it was found by `cppcheck` if you think that's useful.
> 
>     * Update the description to explain why this code block is dead. Something along the lines of "The check that `max_bit_pos == sign_bit_pos` conflicts with the check that `sign_bit_pos < max_bit_pos` in the block surrounding it" or something like that. Definitely mention the issue but don't just repeat the warning without enough context to make sense of it.

Thanks, will update other PR also as your suggested.

https://github.com/llvm/llvm-project/pull/94775