[Lldb-commits] [lldb] [lldb] Fix TestModuleLoadedNotifys API test to work correctly on most of Linux targets (PR #94672)

Dmitry Vasilyev via lldb-commits lldb-commits at lists.llvm.org
Fri Jun 7 01:25:30 PDT 2024


================
@@ -118,6 +118,6 @@ def test_launch_notifications(self):
         # On Linux we get events for ld.so, [vdso], the binary and then all libraries.
 
         avg_solibs_added_per_event = round(
-            float(total_solibs_added) / float(total_modules_added_events)
+            10.0 * float(total_solibs_added) / float(total_modules_added_events)
----------------
slydiman wrote:

> You can't really call it "number of libraries per event" anymore if you multiply by ten.

avg10_solibs_added_per_event ?

> Maybe you could just remove the round call, and compare to 1.0 

No, because assertGreater() expects int parameters.

> Also, this test is very unhermetic

Right, and it seems that the behavior on Darwin is very different. I'd just check `min_modules_per_event >= 1`.


https://github.com/llvm/llvm-project/pull/94672


More information about the lldb-commits mailing list