[Lldb-commits] [lldb] 9293fc7 - [lldb] Include memory stats in statistics summary (#94671)

[via lldb-commits]

Author: Alex Langford
Date: 2024-06-06T13:18:06-07:00
New Revision: 9293fc7981526eaca0a28012f2e5963fff1b830b

URL: https://github.com/llvm/llvm-project/commit/9293fc7981526eaca0a28012f2e5963fff1b830b
DIFF: https://github.com/llvm/llvm-project/commit/9293fc7981526eaca0a28012f2e5963fff1b830b.diff

LOG: [lldb] Include memory stats in statistics summary (#94671)

The summary already includes other size information, e.g. total debug
info size in bytes. The only other way I can get this information is by
dumping all statistics which can be quite large. Adding it to the
summary seems fair.

Added: 
    

Modified: 
    lldb/source/Target/Statistics.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Target/Statistics.cpp b/lldb/source/Target/Statistics.cpp
index be0848573f812..2a5300012511a 100644
--- a/lldb/source/Target/Statistics.cpp
+++ b/lldb/source/Target/Statistics.cpp
@@ -355,14 +355,14 @@ llvm::json::Value DebuggerStats::ReportStatistics(
   }
   global_stats.try_emplace("targets", std::move(json_targets));
 
+  ConstStringStats const_string_stats;
+  json::Object json_memory{
+      {"strings", const_string_stats.ToJSON()},
+  };
+  global_stats.try_emplace("memory", std::move(json_memory));
   if (!summary_only) {
-    ConstStringStats const_string_stats;
-    json::Object json_memory{
-        {"strings", const_string_stats.ToJSON()},
-    };
     json::Value cmd_stats = debugger.GetCommandInterpreter().GetStatistics();
     global_stats.try_emplace("modules", std::move(json_modules));
-    global_stats.try_emplace("memory", std::move(json_memory));
     global_stats.try_emplace("commands", std::move(cmd_stats));
   }