[Lldb-commits] [lldb] [llvm] [lldb] Return an llvm::Expected from DWARFExpression::Evaluate (NFCI) (PR #94420)

David Blaikie via lldb-commits lldb-commits at lists.llvm.org
Thu Jun 6 11:28:55 PDT 2024


================
@@ -2341,9 +2198,7 @@ bool DWARFExpression::Evaluate(
     // the stack by the called expression may be used as return values by prior
     // agreement between the calling and called expressions.
     case DW_OP_call2:
-      if (error_ptr)
-        error_ptr->SetErrorString("Unimplemented opcode DW_OP_call2.");
-      return false;
+      return llvm::createStringError("Unimplemented opcode DW_OP_call2.");
----------------
dwblaikie wrote:

and probably drop the uppercase at the start too?

https://github.com/llvm/llvm-project/pull/94420


More information about the lldb-commits mailing list