[Lldb-commits] [lldb] [lldb/crashlog] Make interactive mode the new default (PR #94575)

Alex Langford via lldb-commits lldb-commits at lists.llvm.org
Thu Jun 6 10:49:03 PDT 2024


================
@@ -1794,8 +1803,36 @@ def SymbolicateCrashLogs(debugger, command_args, result, is_command):
         result.SetError(str(e))
         return
 
+    # To avoid breaking previous users, we should keep supporting previous flag
+    # even if we don't use them / advertise them anymore.
+    if options.interactive:
+        options.mode = CrashLogLoadingMode.interactive
+    elif options.batch:
+        options.mode = CrashLogLoadingMode.batch
+
+    if (
+        options.mode
+        and options.mode != CrashLogLoadingMode.interactive
+        and (options.target_path or options.skip_status)
+    ):
+        print(
+            "Target path (-t) and skipping process status (-s) options can only used in intercative mode (-m=interactive)."
----------------
bulbazord wrote:

typo: `intercative` -> `interactive`

https://github.com/llvm/llvm-project/pull/94575


More information about the lldb-commits mailing list