[Lldb-commits] [lldb] Fix flaky TestDAP_console test. (PR #94494)

Miro Bucko via lldb-commits lldb-commits at lists.llvm.org
Wed Jun 5 10:45:04 PDT 2024


mbucko wrote:

> Would this affect other calls to `collect_console` too? Do we usually look for a particular string? If so, would it make sense to change the function (rather than this particular call site) or have a little helper?

The problem is that the console hasn't had enough time to collect the logs after the process was terminated. This fix will keep collecting the logs until the "exited with status..." log has been collected so that we can check it. The caller could specify 10.0 seconds timeout instead of 1.0 second, but this way the caller can exit earlier rather than forcefully waiting on the timeout. 

https://github.com/llvm/llvm-project/pull/94494


More information about the lldb-commits mailing list