[Lldb-commits] [lldb] [lldb] UpdateFormatsIfNeeded should respect the dynamic value type (PR #93262)

[via lldb-commits]

https://github.com/jimingham approved this pull request.

I wish I knew why the original code was ignoring `GetDynamicValueType` here, when it does use it on the very next line...  The old code looks wrong to me.  However, the places where dynamic values matter for the Format choice are uncommon - you generally set formats on scalars, and scalars don't have dynamic types...  So maybe this was just an expression of "how could this matter"?

In any case, this does seem more correct on the face of it.

https://github.com/llvm/llvm-project/pull/93262