[Lldb-commits] [lldb] [llvm] [lldb] Return an llvm::Expected from DWARFExpression::Evaluate (NFCI) (PR #94420)

[Jonas Devlieghere via lldb-commits]

================
@@ -1350,10 +1300,8 @@ bool DWARFExpression::Evaluate(
       if (pick_idx < stack.size())
         stack.push_back(stack[stack.size() - 1 - pick_idx]);
       else {
-        if (error_ptr)
-          error_ptr->SetErrorStringWithFormat(
-              "Index %u out of range for DW_OP_pick.\n", pick_idx);
-        return false;
+        return llvm::createStringError(
+            "Index %u out of range for DW_OP_pick.\n", pick_idx);
----------------
JDevlieghere wrote:

The capitalization, periods and newlines were the small follows up mentioned offline. There's a lot that can be improved, but I think it deserves its own PR. 

https://github.com/llvm/llvm-project/pull/94420