[Lldb-commits] [lldb] [llvm] [lldb] Return an llvm::Expected from DWARFExpression::Evaluate (NFCI) (PR #94420)

Adrian Prantl via lldb-commits lldb-commits at lists.llvm.org
Wed Jun 5 10:23:09 PDT 2024


================
@@ -1350,10 +1300,8 @@ bool DWARFExpression::Evaluate(
       if (pick_idx < stack.size())
         stack.push_back(stack[stack.size() - 1 - pick_idx]);
       else {
-        if (error_ptr)
-          error_ptr->SetErrorStringWithFormat(
-              "Index %u out of range for DW_OP_pick.\n", pick_idx);
-        return false;
+        return llvm::createStringError(
+            "Index %u out of range for DW_OP_pick.\n", pick_idx);
----------------
adrian-prantl wrote:

drop the extra newline

https://github.com/llvm/llvm-project/pull/94420


More information about the lldb-commits mailing list