[Lldb-commits] [lldb] [lldb] Fixed TestEchoCommands.test running on a remote target (PR #94127)

[Pavel Labath via lldb-commits]

labath wrote:

> > > * LLDB_PLATFORM_URL
> > 
> > 
> > Is that an environment variable or a cmake variable? I don't see a single instance of that string in the entire lldb source tree. Are you sure that's not some downstream feature?
> 
> Sorry for the confusion, the PR for the remote run of Shell tests is coming soon. This PR will be relevant after that.

Ok, I think we should start with that first. And maybe instead of a PR, starting with an RFC to the dev list might be in order, as I'd like to hear how do you plan to implement it, and what do you hope to gain through this functionality.

FWIW, my opinion is that we should not have this functionality, as I don't want to duplicate the remote execution logic for the different kind of tests, and also because I think that most of the tests would not actually be useful in this setup (for example, because a lot of them use hard-coded assembly specific to a single target -- that's one of the criteria I use when choosing what kind of test to write).

If you think there are some tests (classes of tests) that are particularly useful to be run in a remote scenario, then we can consider converting them to an API test.

https://github.com/llvm/llvm-project/pull/94127