[Lldb-commits] [lldb] [lldb] Support reading DW_OP_piece from file address (PR #94026)

[Greg Clayton via lldb-commits]

================
@@ -1077,9 +1077,9 @@ class Target : public std::enable_shared_from_this<Target>,
   // section, then read from the file cache
   // 2 - if there is a process, then read from memory
   // 3 - if there is no process, then read from the file cache
-  size_t ReadMemory(const Address &addr, void *dst, size_t dst_len,
-                    Status &error, bool force_live_memory = false,
-                    lldb::addr_t *load_addr_ptr = nullptr);
+  virtual size_t ReadMemory(const Address &addr, void *dst, size_t dst_len,
----------------
clayborg wrote:

Might be nice to comment that this is virtual for mock testing only. 

https://github.com/llvm/llvm-project/pull/94026