[Lldb-commits] [lldb] Improve performance of .debug_names lookups when DW_IDX_parent attributes are used (PR #91808)

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Mon Jun 3 16:13:53 PDT 2024


clayborg wrote:

This fix was committed as part of:

commit 51dd4eaaa29683c16151f5168e7f8645acbd6e6c
Author: Zequan Wu <zequanwu at google.com>
Date:   Tue May 28 11:49:07 2024 -0400

     Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (#92328)
    
    This reapplies
    https://github.com/llvm/llvm-project/commit/9a7262c2601874e5aa64c5db19746770212d4b44
    (#90663) and added https://github.com/llvm/llvm-project/pull/91808 as a
    fix.
    
    It was causing tests on macos to fail because
    `SymbolFileDWARF::GetForwardDeclCompilerTypeToDIE` returned the map
    owned by this symol file. When there were two symbol files, two
    different maps were created for caching from compiler type to DIE even
    if they are for the same module. The solution is to do the same as
    `SymbolFileDWARF::GetUniqueDWARFASTTypeMap`: inquery
    SymbolFileDWARFDebugMap first to get the shared underlying SymbolFile so
    the map is shared among multiple SymbolFileDWARF.


https://github.com/llvm/llvm-project/pull/91808


More information about the lldb-commits mailing list