[Lldb-commits] [lldb] Summarize std::string's when created from data. (PR #89110)

via lldb-commits lldb-commits at lists.llvm.org
Thu May 23 12:05:37 PDT 2024


================
@@ -2763,10 +2763,10 @@ ValueObjectSP ValueObject::Cast(const CompilerType &compiler_type) {
   ExecutionContextScope *exe_scope
       = ExecutionContext(GetExecutionContextRef())
           .GetBestExecutionContextScope();
-  if (compiler_type.GetByteSize(exe_scope)
-      <= GetCompilerType().GetByteSize(exe_scope) 
-      || m_value.GetValueType() == Value::ValueType::LoadAddress)
-        return DoCast(compiler_type);
+  if (compiler_type.GetByteSize(exe_scope) <=
----------------
jimingham wrote:

This is just a reformatting, right?  We try to only clang-format the code the PR actually changes, (using git-clang-format) as it makes reviews easier.  Also clang-format changes its mind about how to format over time, and so doing other code introduces spurious diffs that make archeology harder. 

https://github.com/llvm/llvm-project/pull/89110


More information about the lldb-commits mailing list