[Lldb-commits] [lldb] [llvm] Add a createError variant without error code (NFC) (PR #93209)

Adrian Prantl via lldb-commits lldb-commits at lists.llvm.org
Thu May 23 11:20:13 PDT 2024


================
@@ -87,8 +87,8 @@ llvm::Error Socket::Initialize() {
   if (err == 0) {
     if (wsaData.wVersion < wVersion) {
       WSACleanup();
-      return llvm::make_error<llvm::StringError>(
-          "WSASock version is not expected.", llvm::inconvertibleErrorCode());
+      return llvm::createStringError("WSASock version is not expected.",
+                                     llvm::inconvertibleErrorCode());
----------------
adrian-prantl wrote:

Yes, that's an oversight. I also didn't try to exhaustively convert everything, just give a sample of the kinds of expected improvements.

https://github.com/llvm/llvm-project/pull/93209


More information about the lldb-commits mailing list