[Lldb-commits] [lldb] [llvm] Add a createError variant without error code (NFC) (PR #93209)

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Thu May 23 10:38:02 PDT 2024


https://github.com/JDevlieghere commented:

I'm in favor of this. I rarely have a meaningful error code and it makes the code needlessly verbose. 

I was going to ask if we wanted to make an overload of the existing `createStringError` but without the error code. But then I noticed that it uses the printf-style formatters (and not the llvm one). I think @bulbazord tried to add a `formatv` overload but that slowed down compilation of LLVM itself. Long story short, I think having this function take an `llvm::Twine` is fine. 

https://github.com/llvm/llvm-project/pull/93209


More information about the lldb-commits mailing list