[Lldb-commits] [lldb] Add AddressRange to SB API (PR #92014)
Greg Clayton via lldb-commits
lldb-commits at lists.llvm.org
Mon May 20 15:35:06 PDT 2024
https://github.com/clayborg requested changes to this pull request.
See inlined comments as the `SBAddressRange::GetDescription()` could have crashed if we had an address with a no section and we did supply a valid target.
So changes needed:
- add a test for a SBAddressRange object that is constructed with a SBAddress that has no section, just a raw address, and we print it out with a valid target (which won't be used because there is no section to resolve)
- change address ranges to be emitted as `[<start-addr>, <end-addr>)` (end the range with a `)` instead of a `]` to indicate the range is not inclusive (for both the case where we have a module name and/or just dumping a load address range or file address range
- make sure an address range that has a valid section, but that section isn't loaded into the target yet that your test can dump it before your run your debug program and see `a.out[0x1000-0x2000)`, and then test once it is running and stopped and the section is loaded and it will print out using the `[<start-load-addr>, <end-load-addr>)`
https://github.com/llvm/llvm-project/pull/92014
More information about the lldb-commits
mailing list