[Lldb-commits] [lldb] SBDebugger: Add new APIs `AddDestroyCallback` and `RemoveDestroyCallback` (PR #89868)

[Greg Clayton via lldb-commits]

================
@@ -731,8 +747,12 @@ class Debugger : public std::enable_shared_from_this<Debugger>,
   lldb::TargetSP m_dummy_target_sp;
   Diagnostics::CallbackID m_diagnostics_callback_id;
 
-  lldb_private::DebuggerDestroyCallback m_destroy_callback = nullptr;
-  void *m_destroy_callback_baton = nullptr;
+  std::mutex m_destroy_callback_mutex;
+  lldb::destroy_callback_token_t m_destroy_callback_next_token = 0;
+  typedef std::tuple<lldb::destroy_callback_token_t,
+                     lldb_private::DebuggerDestroyCallback, void *>
----------------
clayborg wrote:

Instead of a tuple, please create a struct type. Using tuples isn't very readable even though it works:
```
struct DestroyCallbackInfo {
  lldb::callback_token_t token;
  lldb_private::DebuggerDestroyCallback callback;
  void *baton;
};
```

https://github.com/llvm/llvm-project/pull/89868