[Lldb-commits] [lldb] Allow multiple destroy callbacks in `SBDebugger::SetDestroyCallback()` (PR #89868)

via lldb-commits lldb-commits at lists.llvm.org
Wed Apr 24 14:58:58 PDT 2024


royitaqi wrote:

Hi @JDevlieghere and @jimingham,

I have updated the PR to add `AddDestroyCallback()`, `ClearDestroyCallback()`, and tests for these. Also updated `SetDestroyCallback()` to work with the new field `std::vector<std::pair<callback, baton>>`.

Hope it looks better now. LMK if anything else needs to be added/changed.

--

BTW, noob as I am, is there anything I need to do to change the PR's state "Changes requested"?  E.g. In some other diff review tools, there is a thing to flip the state into "Ready for review".

https://github.com/llvm/llvm-project/pull/89868


More information about the lldb-commits mailing list