[Lldb-commits] [lldb] [lldb] Replace condition that always evaluates to false (PR #89685)
Troy Butler via lldb-commits
lldb-commits at lists.llvm.org
Mon Apr 22 16:32:11 PDT 2024
Troy-Butler wrote:
> Otherwise this LGTM!
> Even though you link the issue, I would recommend also summarizing the issue in the commit. Something like "The current code is checking the validity of `obj` twice, instead of checking the new `str_obj` pointer."
>
> Otherwise this LGTM!
I appreciate the advice, thank you!
Also, I do not have the ability to merge. If everything looks good on your end, can you please merge with main? Thank you again!
https://github.com/llvm/llvm-project/pull/89685
More information about the lldb-commits
mailing list