[Lldb-commits] [lldb] [lldb] Replace condition that always evaluates to false (PR #89685)

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Mon Apr 22 16:23:12 PDT 2024


https://github.com/JDevlieghere approved this pull request.

Even though you link the issue, I would recommend also summarizing the issue in the commit. Something like "The current code is checking the validity of `obj` twice, instead of checking the new `str_obj` pointer." 

Otherwise this LGTM!

https://github.com/llvm/llvm-project/pull/89685


More information about the lldb-commits mailing list