[Lldb-commits] [lldb] [lldb] Have lldb-server assign ports to children in platform mode (PR #88845)

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Tue Apr 16 06:09:17 PDT 2024


================
@@ -301,13 +294,31 @@ int main_platform(int argc, char *argv[]) {
       exit(socket_error);
     }
     printf("Connection established.\n");
+
+    std::optional<uint16_t> port = 0;
----------------
DavidSpickett wrote:

If we're going to use optional then this should be left to default construct to std::nullopt (https://en.cppreference.com/w/cpp/utility/optional/nullopt_t) (the equivalent of Haskell Maybe's "Nothing" state).

https://github.com/llvm/llvm-project/pull/88845


More information about the lldb-commits mailing list