[Lldb-commits] [lldb] [lldb] Have lldb-server assign ports to children in platform mode (PR #88845)

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Tue Apr 16 06:09:16 PDT 2024


================
@@ -301,13 +294,31 @@ int main_platform(int argc, char *argv[]) {
       exit(socket_error);
     }
     printf("Connection established.\n");
+
+    std::optional<uint16_t> port = 0;
     if (g_server) {
       // Collect child zombie processes.
 #if !defined(_WIN32)
-      while (waitpid(-1, nullptr, WNOHANG) > 0)
-        ;
+      auto waitResult = waitpid(-1, nullptr, WNOHANG);
+      while (waitResult > 0) {
----------------
DavidSpickett wrote:

Could be `while (int waitResult = waitpid(.... ) {`.

https://github.com/llvm/llvm-project/pull/88845


More information about the lldb-commits mailing list