[Lldb-commits] [lldb] 0adccd1 - [lldb] Allow languages to filter breakpoints set by line (#83908)
via lldb-commits
lldb-commits at lists.llvm.org
Thu Mar 14 09:40:03 PDT 2024
Author: Felipe de Azevedo Piovezan
Date: 2024-03-14T09:40:00-07:00
New Revision: 0adccd1a7fd8e30650f76bd33471de28b7939455
URL: https://github.com/llvm/llvm-project/commit/0adccd1a7fd8e30650f76bd33471de28b7939455
DIFF: https://github.com/llvm/llvm-project/commit/0adccd1a7fd8e30650f76bd33471de28b7939455.diff
LOG: [lldb] Allow languages to filter breakpoints set by line (#83908)
Some languages may create artificial functions that have no real user
code, even though there is line table information for them. One such
case is with coroutine code that receives the CoroSplitter
transformation in LLVM IR. That code transformation creates many
different Functions, cloning one Instruction into many Instructions in
many different Functions and copying the associated debug locations.
It would be difficult to make that pass delete debug locations of cloned
instructions in a language agnostic way (is it even possible?), but LLDB
can ignore certain locations by querying its Language APIs and having it
decide based on, for example, mangling information.
Added:
Modified:
lldb/include/lldb/Target/Language.h
lldb/source/Breakpoint/BreakpointResolver.cpp
lldb/source/Core/Debugger.cpp
lldb/source/Target/Language.cpp
lldb/source/Target/TargetProperties.td
Removed:
################################################################################
diff --git a/lldb/include/lldb/Target/Language.h b/lldb/include/lldb/Target/Language.h
index 0cbd8a32dccd54..67714e6fdf942e 100644
--- a/lldb/include/lldb/Target/Language.h
+++ b/lldb/include/lldb/Target/Language.h
@@ -26,6 +26,15 @@
namespace lldb_private {
+class LanguageProperties : public Properties {
+public:
+ LanguageProperties();
+
+ static llvm::StringRef GetSettingName();
+
+ bool GetEnableFilterForLineBreakpoints() const;
+};
+
class Language : public PluginInterface {
public:
class TypeScavenger {
@@ -324,6 +333,8 @@ class Language : public PluginInterface {
static LanguageSet GetLanguagesSupportingTypeSystemsForExpressions();
static LanguageSet GetLanguagesSupportingREPLs();
+ static LanguageProperties &GetGlobalLanguageProperties();
+
// Given a mangled function name, calculates some alternative manglings since
// the compiler mangling may not line up with the symbol we are expecting.
virtual std::vector<ConstString>
@@ -339,6 +350,15 @@ class Language : public PluginInterface {
virtual llvm::StringRef GetInstanceVariableName() { return {}; }
+ /// Returns true if this SymbolContext should be ignored when setting
+ /// breakpoints by line (number or regex). Helpful for languages that create
+ /// artificial functions without meaningful user code associated with them
+ /// (e.g. code that gets expanded in late compilation stages, like by
+ /// CoroSplitter).
+ virtual bool IgnoreForLineBreakpoints(const SymbolContext &) const {
+ return false;
+ }
+
protected:
// Classes that inherit from Language can see and modify these
diff --git a/lldb/source/Breakpoint/BreakpointResolver.cpp b/lldb/source/Breakpoint/BreakpointResolver.cpp
index bc6348716ef418..1861a0fe7c4fe4 100644
--- a/lldb/source/Breakpoint/BreakpointResolver.cpp
+++ b/lldb/source/Breakpoint/BreakpointResolver.cpp
@@ -23,6 +23,7 @@
#include "lldb/Symbol/CompileUnit.h"
#include "lldb/Symbol/Function.h"
#include "lldb/Symbol/SymbolContext.h"
+#include "lldb/Target/Language.h"
#include "lldb/Target/Target.h"
#include "lldb/Utility/LLDBLog.h"
#include "lldb/Utility/Log.h"
@@ -203,8 +204,15 @@ void BreakpointResolver::SetSCMatchesByLine(
SearchFilter &filter, SymbolContextList &sc_list, bool skip_prologue,
llvm::StringRef log_ident, uint32_t line, std::optional<uint16_t> column) {
llvm::SmallVector<SymbolContext, 16> all_scs;
- for (uint32_t i = 0; i < sc_list.GetSize(); ++i)
- all_scs.push_back(sc_list[i]);
+
+ for (const auto &sc : sc_list) {
+ if (Language::GetGlobalLanguageProperties()
+ .GetEnableFilterForLineBreakpoints())
+ if (Language *lang = Language::FindPlugin(sc.GetLanguage());
+ lang && lang->IgnoreForLineBreakpoints(sc))
+ continue;
+ all_scs.push_back(sc);
+ }
while (all_scs.size()) {
uint32_t closest_line = UINT32_MAX;
diff --git a/lldb/source/Core/Debugger.cpp b/lldb/source/Core/Debugger.cpp
index 90aabde2b764f1..ebd112110e5f2d 100644
--- a/lldb/source/Core/Debugger.cpp
+++ b/lldb/source/Core/Debugger.cpp
@@ -860,6 +860,9 @@ Debugger::Debugger(lldb::LogOutputCallback log_callback, void *baton)
m_collection_sp->AppendProperty(
"symbols", "Symbol lookup and cache settings.", true,
ModuleList::GetGlobalModuleListProperties().GetValueProperties());
+ m_collection_sp->AppendProperty(
+ LanguageProperties::GetSettingName(), "Language settings.", true,
+ Language::GetGlobalLanguageProperties().GetValueProperties());
if (m_command_interpreter_up) {
m_collection_sp->AppendProperty(
"interpreter",
diff --git a/lldb/source/Target/Language.cpp b/lldb/source/Target/Language.cpp
index caf3e6636c1de1..1542c8cb68ce65 100644
--- a/lldb/source/Target/Language.cpp
+++ b/lldb/source/Target/Language.cpp
@@ -13,6 +13,7 @@
#include "lldb/Target/Language.h"
#include "lldb/Core/PluginManager.h"
+#include "lldb/Interpreter/OptionValueProperties.h"
#include "lldb/Symbol/SymbolFile.h"
#include "lldb/Symbol/TypeList.h"
#include "lldb/Target/Target.h"
@@ -27,6 +28,35 @@ using namespace lldb_private::formatters;
typedef std::unique_ptr<Language> LanguageUP;
typedef std::map<lldb::LanguageType, LanguageUP> LanguagesMap;
+#define LLDB_PROPERTIES_language
+#include "TargetProperties.inc"
+
+enum {
+#define LLDB_PROPERTIES_language
+#include "TargetPropertiesEnum.inc"
+};
+
+LanguageProperties &Language::GetGlobalLanguageProperties() {
+ static LanguageProperties g_settings;
+ return g_settings;
+}
+
+llvm::StringRef LanguageProperties::GetSettingName() {
+ static constexpr llvm::StringLiteral g_setting_name("language");
+ return g_setting_name;
+}
+
+LanguageProperties::LanguageProperties() {
+ m_collection_sp = std::make_shared<OptionValueProperties>(GetSettingName());
+ m_collection_sp->Initialize(g_language_properties);
+}
+
+bool LanguageProperties::GetEnableFilterForLineBreakpoints() const {
+ const uint32_t idx = ePropertyEnableFilterForLineBreakpoints;
+ return GetPropertyAtIndexAs<bool>(
+ idx, g_language_properties[idx].default_uint_value != 0);
+}
+
static LanguagesMap &GetLanguagesMap() {
static LanguagesMap *g_map = nullptr;
static llvm::once_flag g_initialize;
diff --git a/lldb/source/Target/TargetProperties.td b/lldb/source/Target/TargetProperties.td
index d2fccdb7b9b39c..7f79218e0a6a4d 100644
--- a/lldb/source/Target/TargetProperties.td
+++ b/lldb/source/Target/TargetProperties.td
@@ -311,3 +311,9 @@ let Definition = "thread" in {
DefaultUnsignedValue<600000>,
Desc<"Maximum number of frames to backtrace.">;
}
+
+let Definition = "language" in {
+ def EnableFilterForLineBreakpoints: Property<"enable-filter-for-line-breakpoints", "Boolean">,
+ DefaultTrue,
+ Desc<"If true, allow Language plugins to filter locations when setting breakpoints by line number or regex.">;
+}
More information about the lldb-commits
mailing list