[Lldb-commits] [lldb] [lldb] Migrate distutils.version.LooseVersion to packaging (PR #82066)

Felipe de Azevedo Piovezan via lldb-commits lldb-commits at lists.llvm.org
Fri Feb 16 21:43:18 PST 2024


================
@@ -308,13 +308,21 @@ def expectedCompilerVersion(compiler_version):
         return operator in [">", ">=", "!", "!=", "not"]
 
     if operator == ">":
-        return LooseVersion(test_compiler_version) > LooseVersion(version)
+        return packaging.version.parse(test_compiler_version) > packaging.version.parse(
----------------
felipepiovezan wrote:

all these would probably be easier to read if we factored out both parse calls into a variable, as they are repeated everywhere. Don't feel strongly about it though

https://github.com/llvm/llvm-project/pull/82066


More information about the lldb-commits mailing list