[Lldb-commits] [lldb] [lldb-dap] Do not write over the existing error if launchCommands fail during debugger launch. (PR #82051)

[via lldb-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {darker}-->


:warning: Python code formatter, darker found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
darker --check --diff -r 2de269a641e4ffbb7a44e559c4c0a91bb66df823...f76dbe10e30c84aadaf33c597fe81bc0a285c995 lldb/packages/Python/lldbsuite/test/tools/lldb-dap/lldbdap_testcase.py lldb/test/API/tools/lldb-dap/launch/TestDAP_launch.py
``````````

</details>

<details>
<summary>
View the diff from darker here.
</summary>

``````````diff
--- packages/Python/lldbsuite/test/tools/lldb-dap/lldbdap_testcase.py	2024-02-16 23:15:51.000000 +0000
+++ packages/Python/lldbsuite/test/tools/lldb-dap/lldbdap_testcase.py	2024-02-16 23:18:32.138239 +0000
@@ -120,11 +120,11 @@
         lines = output.splitlines()
         prefix = "(lldb) "
         for cmd in commands:
             found = False
             for line in lines:
-                if len(cmd) > 0 and (cmd[0] == '!' or cmd[0] == '?'):
+                if len(cmd) > 0 and (cmd[0] == "!" or cmd[0] == "?"):
                     cmd = cmd[1:]
                 if line.startswith(prefix) and cmd in line:
                     found = True
                     break
             self.assertTrue(
--- test/API/tools/lldb-dap/launch/TestDAP_launch.py	2024-02-16 23:15:51.000000 +0000
+++ test/API/tools/lldb-dap/launch/TestDAP_launch.py	2024-02-16 23:18:32.288817 +0000
@@ -425,13 +425,11 @@
         """
         self.build_and_create_debug_adaptor()
         program = self.getBuildArtifact("a.out")
 
         # Run an invalid launch command, in this case a bad path.
-        launchCommands = [
-            '!target create "/bad/path%s"' % (program)
-        ]
+        launchCommands = ['!target create "/bad/path%s"' % (program)]
 
         initCommands = ["target list", "platform list"]
         preRunCommands = ["image list a.out", "image dump sections a.out"]
         response = self.launch(
             program,
@@ -441,12 +439,12 @@
             expectFailure=True,
         )
 
         self.assertFalse(response["success"])
         self.assertRegex(
-            response["message"], 
-            r"Failed to run launch commands\. See the Debug Console for more details"
+            response["message"],
+            r"Failed to run launch commands\. See the Debug Console for more details",
         )
 
         # Get output from the console. This should contain both the
         # "initCommands" and the "preRunCommands".
         output = self.get_console()

``````````

</details>


https://github.com/llvm/llvm-project/pull/82051