[Lldb-commits] [lldb] Re-land [lldb-dap] Add support for data breakpoint. (PR #81909)

[Zequan Wu via lldb-commits]

ZequanWu wrote:

DAP adds a new request `DataAddressBreakpointInfo` at https://github.com/microsoft/debug-adapter-protocol/pull/461 with  the following format to allow setting watchpoints at given address and size:
```
interface DataAddressBreakpointInfoRequest extends Request {
  command: 'DataAddressBreakpointInfo';

  arguments: DataAddressBreakpointInfoArguments;
}
interface DataAddressBreakpointInfoArguments {
  /**
   * The address of the data for which to obtain breakpoint information.
   * Treated as a hex value if prefixed with `0x`, or as a decimal value
   * otherwise.
   */
  address?: string;

  /**
   * If passed, requests breakpoint information for an exclusive byte range
   * rather than a single address. The range extends the given number of `bytes`
   * from the start `address`.
   * Treated as a hex value if prefixed with `0x`, or as a decimal value
   * otherwise.
   */
  bytes?: string;
}
```

This is kind of overlap with the existing made-up `${number of bytes}@${expression}`. If we choose to use the made-up, the new request seems not necessary to add because expression could be an address as well.

https://github.com/llvm/llvm-project/pull/81909