[Lldb-commits] [lldb] [lldb] Add comment on cross printing of summary/value (PR #81681)

[Dave Lee via lldb-commits]

https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/81681

>From 35a48898e20ba45db829dbf137d88a8417dd4d7c Mon Sep 17 00:00:00 2001
From: Dave Lee <davelee.com at gmail.com>
Date: Tue, 13 Feb 2024 14:43:33 -0800
Subject: [PATCH 1/2] [lldb] Add comment on cross printing of summary/value

---
 lldb/source/Core/ValueObject.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lldb/source/Core/ValueObject.cpp b/lldb/source/Core/ValueObject.cpp
index e80042826f7d64..2a2bb128d33c57 100644
--- a/lldb/source/Core/ValueObject.cpp
+++ b/lldb/source/Core/ValueObject.cpp
@@ -1312,6 +1312,7 @@ bool ValueObject::DumpPrintableRepresentation(
       break;
     }
 
+    // Try summary if no value, and value if no summary.
     if (str.empty()) {
       if (val_obj_display == eValueObjectRepresentationStyleValue)
         str = GetSummaryAsCString();

>From 49340890b515349a8858f606d21eebdabbc6fd69 Mon Sep 17 00:00:00 2001
From: Dave Lee <davelee.com at gmail.com>
Date: Wed, 14 Feb 2024 13:11:47 -0800
Subject: [PATCH 2/2] Clarify comment

---
 lldb/source/Core/ValueObject.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lldb/source/Core/ValueObject.cpp b/lldb/source/Core/ValueObject.cpp
index 2a2bb128d33c57..840b100c70ddaa 100644
--- a/lldb/source/Core/ValueObject.cpp
+++ b/lldb/source/Core/ValueObject.cpp
@@ -1312,7 +1312,8 @@ bool ValueObject::DumpPrintableRepresentation(
       break;
     }
 
-    // Try summary if no value, and value if no summary.
+    // If the requested display style produced no output, try falling back to
+    // alternative presentations.
     if (str.empty()) {
       if (val_obj_display == eValueObjectRepresentationStyleValue)
         str = GetSummaryAsCString();