[Lldb-commits] [clang] [llvm] [lldb] [clang] Split out DebugOptions.def into its own top-level options group. (PR #75530)

[Jan Svoboda via lldb-commits]

================
@@ -11,46 +11,13 @@
 
 namespace clang {
 
-CodeGenOptions::CodeGenOptions() {
-#define CODEGENOPT(Name, Bits, Default) Name = Default;
-#define ENUM_CODEGENOPT(Name, Type, Bits, Default) set##Name(Default);
-#include "clang/Basic/CodeGenOptions.def"
+CodeGenOptions::CodeGenOptions() { resetNonModularOptions(); }
----------------
jansvoboda11 wrote:

I find this confusing: why are we resetting only the non-modular options here? I'd expect all options to be set to default here. Maybe create extra helper function `resetAllOptions()` that will call to `resetNonModularOptions()` and explain how modular options are handled?

https://github.com/llvm/llvm-project/pull/75530