[Lldb-commits] [lldb] [lldb][NFCI] Remove unused parameter from BreakpointResolver*::CreateFromStructuredData (PR #75374)

via lldb-commits lldb-commits at lists.llvm.org
Thu Dec 14 09:42:00 PST 2023


jimingham wrote:

You don't need the breakpoint to create the resolver.  It's been a while, but I imagine I was passing in the breakpoint here so that if there were errors with deserializing the resolver from the structured data we could mention the breakpoint number.  But that's not really necessary, you can add the breakpoint number to the error reporting after you get the error back from CreateFromStructuredData.  So this looks fine to me.

https://github.com/llvm/llvm-project/pull/75374


More information about the lldb-commits mailing list