[Lldb-commits] [lldb] f59fed2 - [lldb][PDB] TypeQuery parameter should be ConstString

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Wed Dec 13 04:46:25 PST 2023


Author: David Spickett
Date: 2023-12-13T12:46:16Z
New Revision: f59fed261e30ddeecb6c6bfb53e47ecd4b124e7a

URL: https://github.com/llvm/llvm-project/commit/f59fed261e30ddeecb6c6bfb53e47ecd4b124e7a
DIFF: https://github.com/llvm/llvm-project/commit/f59fed261e30ddeecb6c6bfb53e47ecd4b124e7a.diff

LOG: [lldb][PDB] TypeQuery parameter should be ConstString

Added: 
    

Modified: 
    lldb/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp b/lldb/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp
index c09ed162c023d8..cdaa4fafa4c873 100644
--- a/lldb/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp
+++ b/lldb/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp
@@ -414,8 +414,9 @@ TEST_F(SymbolFilePDBTests, TestNestedClassTypes) {
 
   auto ClassCompilerDeclCtx = CompilerDeclContext(clang_ast_ctx, ClassDeclCtx);
   TypeResults query_results_nested;
-  symfile->FindTypes(TypeQuery(ClassCompilerDeclCtx, "NestedClass"),
-                     query_results_nested);
+  symfile->FindTypes(
+      TypeQuery(ClassCompilerDeclCtx, ConstString("NestedClass")),
+      query_results_nested);
   TypeMap &more_results = query_results_nested.GetTypeMap();
   EXPECT_LE(1u, more_results.GetSize());
 
@@ -458,7 +459,7 @@ TEST_F(SymbolFilePDBTests, TestClassInNamespace) {
   EXPECT_TRUE(ns_namespace_decl_ctx.IsValid());
 
   TypeResults query_results;
-  symfile->FindTypes(TypeQuery(ns_namespace_decl_ctx, "NSClass"),
+  symfile->FindTypes(TypeQuery(ns_namespace_decl_ctx, ConstString("NSClass")),
                      query_results);
   TypeMap &results = query_results.GetTypeMap();
   EXPECT_EQ(1u, results.GetSize());


        


More information about the lldb-commits mailing list