[Lldb-commits] [lldb] [lldb-dap] Implement command directives (PR #74808)

[Walter Erquinigo via lldb-commits]

walter-erquinigo wrote:

@clayborg , I actually insist on aborting on failure for this feature. You mention:

> It would be nice if the RunLLDBCommands function could take an extra bool &fatal_error that clients could check after running when needed to decide what to do if this is set to true due to any ! prefixed commands failing.

That would imply that some commands would have a specific behavior upon a failed ! command, and other commands would have a different behavior. That makes this feature a bit hard to use by actual users, as it wouldn't have a consistent behavior, unlike ? commands. 

What I wanted to achieve with ! was to have a way for users to tell the lldb-dap: hey, this command is critical for my flow, abort if it fails. Having a mild behavior instead of aborting kind of defeats the purpose of this feature.

https://github.com/llvm/llvm-project/pull/74808