[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

Will Hawkins via lldb-commits lldb-commits at lists.llvm.org
Fri Dec 8 23:20:02 PST 2023


================
@@ -340,26 +340,22 @@ class ModuleList {
                                        lldb::SymbolType symbol_type,
                                        SymbolContextList &sc_list) const;
 
-  /// Find types by name.
+  /// Find types using a type matching object that contains all search
+  /// parameters.
   ///
   /// \param[in] search_first
   ///     If non-null, this module will be searched before any other
   ///     modules.
   ///
-  /// \param[in] name
-  ///     The name of the type we are looking for.
-  ///
-  /// \param[in] max_matches
-  ///     Allow the number of matches to be limited to \a
-  ///     max_matches. Specify UINT32_MAX to get all possible matches.
-  ///
-  /// \param[out] types
-  ///     A type list gets populated with any matches.
+  /// \param[in] query
+  ///     A type matching object that contains all of the details of the type
----------------
hawkinsw wrote:

```suggestion
  ///     A type-matching object that contains all of the details of the type
```

https://github.com/llvm/llvm-project/pull/74786


More information about the lldb-commits mailing list