[Lldb-commits] [lldb] [lldb] colorize symbols in image lookup with a regex pattern (PR #69422)

[David Spickett via lldb-commits]

=?utf-8?q?José?= L. Junior <josejunior at 10xengineers.ai>,taalhaataahir0102
 <23100293 at lums.edu.pk>,taalhaataahir0102 <23100293 at lums.edu.pk>,taalhaataahir0102
 <23100293 at lums.edu.pk>,taalhaataahir0102 <23100293 at lums.edu.pk>,
=?utf-8?q?José?= L. Junior <josejunior at 10xengineers.ai>,
=?utf-8?q?José?= L. Junior <josejunior at 10xengineers.ai>,
=?utf-8?q?José?= L. Junior <josejunior at 10xengineers.ai>,
=?utf-8?q?José?= L. Junior <josejunior at 10xengineers.ai>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/69422 at github.com>


DavidSpickett wrote:

Ok bots look good, so congratulations on landing this change! :partying_face: 

(you will have some email from build bots, it's a good idea to go look at the failures just to see what they look like, but I have fixed them)

Sounds like you already have ideas for follow ups. You should also add a release note (https://github.com/llvm/llvm-project/blob/main/llvm/docs/ReleaseNotes.rst#changes-to-lldb) at some point when you're happy with the feature overall. Or in other words, when it can be described in 1 or 2 sentences without a lot of caveats.

I'm trying the feature myself and noticing the thing you said about the symbol context. Even when looking up symbols on a running process, when we print a `Summary: ` line, `target_sp` is always nullptr. Surprising, and a bit annoying as a majority of the symbols in my searches didn't have a `Name: ` line.

(though one can work around this by adding `-v`)

Could be that there's never been a need for target here, and as you said, what you really want is the debugger settings. So perhaps the better route is to add a link back to those.

https://github.com/llvm/llvm-project/pull/69422