[Lldb-commits] [lldb] [clang] fixing issue #64441 (PR #74814)

[Jeevan Ghimire via lldb-commits]

https://github.com/jeevanghimire created https://github.com/llvm/llvm-project/pull/74814

removing using namespace std;

and  assigning the fully qualified name for better naming in codebase

>From c137cd0ba81f82dbca2feb01bb8d088e42f0c524 Mon Sep 17 00:00:00 2001
From: Jeevan Ghimire <imjeevanghimire at gmail.com>
Date: Fri, 8 Dec 2023 13:36:51 +0545
Subject: [PATCH] fixing issue #64441

removing using namespace std;

and  assigning the fully qualified name for better naming in codebase
---
 clang/test/Index/usrs.cpp                 |  2 +-
 lldb/test/API/lang/cpp/namespace/main.cpp | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/clang/test/Index/usrs.cpp b/clang/test/Index/usrs.cpp
index dbfa44f4b6764..2eeeb82cc5c1f 100644
--- a/clang/test/Index/usrs.cpp
+++ b/clang/test/Index/usrs.cpp
@@ -57,7 +57,7 @@ extern "C" {
 
 namespace foo_alias = foo;
 
-using namespace foo;
+//removing using namespace foo;
 
 namespace foo_alias2 = foo;
 
diff --git a/lldb/test/API/lang/cpp/namespace/main.cpp b/lldb/test/API/lang/cpp/namespace/main.cpp
index 6a8efa160766b..28d5421e1d33d 100644
--- a/lldb/test/API/lang/cpp/namespace/main.cpp
+++ b/lldb/test/API/lang/cpp/namespace/main.cpp
@@ -34,7 +34,7 @@ namespace A {
         int myfunc (int a);
         int myfunc2(int a)
         {
-             return a + 2;
+                return a + 2; //just changing tab not much
         }
         float myfunc (float f)
         {
@@ -56,10 +56,10 @@ namespace Foo = A::B;   // namespace alias
 
 using Foo::myfunc;      // using declaration
 
-using namespace Foo;    // using directive
+//removing namespace foo; for quality naming 
 
-namespace A {
-    namespace B {
+namespace fo::A {
+    namespace foo::B {
         using namespace Y;
         int k;
     }
@@ -140,5 +140,5 @@ main (int argc, char const *argv[])
     ::B::Bar bb;
     A::B::Bar ab;
     return Foo::myfunc(12) + bb.x() + ab.y() + NS1::NS2::Foo{}.bar() +
-           NS2::Foo{}.bar();
+            NS2::Foo{}.bar();
 }