[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

[via lldb-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {darker}-->


:warning: Python code formatter, darker found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
darker --check --diff -r 42bba97fc24f045f593fc26f998bac9b08633255...5adebf6f6068ef1eb8e5a4dbb02a52d8c21b1b3c lldb/test/API/functionalities/type_find_first/TestFindFirstType.py lldb/test/API/lang/cpp/unique-types4/TestUniqueTypes4.py
``````````

</details>

<details>
<summary>
View the diff from darker here.
</summary>

``````````diff
--- functionalities/type_find_first/TestFindFirstType.py	2023-12-07 23:25:59.000000 +0000
+++ functionalities/type_find_first/TestFindFirstType.py	2023-12-07 23:42:34.347989 +0000
@@ -6,22 +6,21 @@
 from lldbsuite.test.lldbtest import *
 from lldbsuite.test import lldbutil
 
 
 class TypeFindFirstTestCase(TestBase):
-
     NO_DEBUG_INFO_TESTCASE = True
 
     def test_find_first_type(self):
         """
-            Test SBTarget::FindFirstType() and SBModule::FindFirstType() APIs.
+        Test SBTarget::FindFirstType() and SBModule::FindFirstType() APIs.
 
-            This function had regressed after some past modification of the type
-            lookup internal code where if we had multiple types with the same
-            basename, FindFirstType() could end up failing depending on which
-            type was found first in the debug info indexes. This test will
-            ensure this doesn't regress in the future.
+        This function had regressed after some past modification of the type
+        lookup internal code where if we had multiple types with the same
+        basename, FindFirstType() could end up failing depending on which
+        type was found first in the debug info indexes. This test will
+        ensure this doesn't regress in the future.
         """
         self.build()
         target = self.createTestTarget()
         # Test the SBTarget APIs for FindFirstType
         integer_type = target.FindFirstType("Integer::Point")
--- lang/cpp/unique-types4/TestUniqueTypes4.py	2023-12-07 23:25:59.000000 +0000
+++ lang/cpp/unique-types4/TestUniqueTypes4.py	2023-12-07 23:42:34.377368 +0000
@@ -17,28 +17,31 @@
         lldbutil.run_to_source_breakpoint(
             self, "// Set breakpoint here", lldb.SBFileSpec("main.cpp")
         )
         # FIXME: these should successfully print the values
         self.expect(
-            "print ns::Foo<double>::value", substrs=["no template named 'Foo' in namespace 'ns'"], error=True
+            "print ns::Foo<double>::value",
+            substrs=["no template named 'Foo' in namespace 'ns'"],
+            error=True,
         )
         self.expect(
-            "print ns::Foo<int>::value", substrs=["no template named 'Foo' in namespace 'ns'"], error=True
+            "print ns::Foo<int>::value",
+            substrs=["no template named 'Foo' in namespace 'ns'"],
+            error=True,
         )
         self.expect(
-            "print ns::Bar<double>::value", substrs=["no template named 'Bar' in namespace 'ns'"], error=True
+            "print ns::Bar<double>::value",
+            substrs=["no template named 'Bar' in namespace 'ns'"],
+            error=True,
         )
         self.expect(
-            "print ns::Bar<int>::value", substrs=["no template named 'Bar' in namespace 'ns'"], error=True
+            "print ns::Bar<int>::value",
+            substrs=["no template named 'Bar' in namespace 'ns'"],
+            error=True,
         )
-        self.expect(
-            "print ns::FooDouble::value", substrs=["(double) 0"]
-        )
-        self.expect(
-            "print ns::FooInt::value", substrs=["(int) 0"]
-        )
-
+        self.expect("print ns::FooDouble::value", substrs=["(double) 0"])
+        self.expect("print ns::FooInt::value", substrs=["(int) 0"])
 
     @skipIf(compiler=no_match("clang"))
     @skipIf(compiler_version=["<", "15.0"])
     def test_simple_template_names(self):
         self.do_test(dict(CFLAGS_EXTRAS="-gsimple-template-names"))

``````````

</details>


https://github.com/llvm/llvm-project/pull/74786