[Lldb-commits] [lldb] [lldb][progress] Add discrete boolean flag to progress reports (PR #69516)

Chelsea Cassanova via lldb-commits lldb-commits at lists.llvm.org
Thu Dec 7 13:54:12 PST 2023


================
@@ -2225,7 +2225,8 @@ void ObjectFileMachO::ParseSymtab(Symtab &symtab) {
   const char *file_name = file.GetFilename().AsCString("<Unknown>");
   LLDB_SCOPED_TIMERF("ObjectFileMachO::ParseSymtab () module = %s", file_name);
   LLDB_LOG(log, "Parsing symbol table for {0}", file_name);
-  Progress progress(llvm::formatv("Parsing symbol table for {0}", file_name));
+  Progress progress(llvm::formatv("Parsing symbol table for {0}", file_name),
+                    Progress::ProgressReportType::eAggregateProgressReport);
----------------
chelcassanova wrote:

The intention is that if `is_aggregate == false` then the progress report type can be grouped together in LLDB under one large umbrella progress report for that operation whereas if `is_aggregate == true` then the IDE could potentially filter out those progress reports since each progress report happening individually means that they look spammy in an IDE.

Instead of using a string as a `category` field we could have each progress report type/category be an enum in `lldb_enumerations.h` i.e. `ProgressReportType/Category == eProgressSymbolTableParse` or `eProgressDWARFIndexing`

https://github.com/llvm/llvm-project/pull/69516


More information about the lldb-commits mailing list