[Lldb-commits] [lldb] [lldb] colorize symbols in image lookup with a regex pattern (PR #69422)

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Thu Dec 7 06:57:21 PST 2023


=?utf-8?q?José?= L. Junior <josejunior at 10xengineers.ai>,taalhaataahir0102
 <23100293 at lums.edu.pk>,taalhaataahir0102 <23100293 at lums.edu.pk>,taalhaataahir0102
 <23100293 at lums.edu.pk>,taalhaataahir0102 <23100293 at lums.edu.pk>,
=?utf-8?q?José?= L. Junior <josejunior at 10xengineers.ai>,
=?utf-8?q?José?= L. Junior <josejunior at 10xengineers.ai>,
=?utf-8?q?José?= L. Junior <josejunior at 10xengineers.ai>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/69422 at github.com>


DavidSpickett wrote:

Wait, one last thing :)

> If the prefix and suffix are empty, we can also take this shortcut, right?

If the prefix *and* suffix are empty. Not prefix or suffix is empty.

Also please add a couple of tests where you set only suffix, and only prefix. To validate that.

https://github.com/llvm/llvm-project/pull/69422


More information about the lldb-commits mailing list