[Lldb-commits] [lldb] [lldb][progress] Add discrete boolean flag to progress reports (PR #69516)

Jason Molenda via lldb-commits lldb-commits at lists.llvm.org
Tue Dec 5 15:09:46 PST 2023


================
@@ -55,6 +55,11 @@ namespace lldb_private {
 
 class Progress {
 public:
+  /// Enum that indicates the type of progress report
+  enum class ProgressReportType {
+    eAggregateProgressReport,
+    eNonAggregateProgressReport
----------------
jasonmolenda wrote:

I wonder if it might be a little easier to intuit if the enums were eAggregateProgressReport and eIndividualProgressReport?  Then someone might look at this and say "oh I have a single thing I'm providing progress on, I probably want eIndividualProgressReport".  I don't feel strongly that I'm correct here, just throwing it out.

https://github.com/llvm/llvm-project/pull/69516


More information about the lldb-commits mailing list