[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class (second try). (PR #73472)

Felipe de Azevedo Piovezan via lldb-commits lldb-commits at lists.llvm.org
Mon Nov 27 14:40:03 PST 2023


================
@@ -436,8 +482,8 @@ class CompilerType {
                      ExecutionContextScope *exe_scope);
 
   /// Dump to stdout.
-  void DumpTypeDescription(lldb::DescriptionLevel level =
-                           lldb::eDescriptionLevelFull) const;
----------------
felipepiovezan wrote:

I understand the desire to fix formatting issues, but let's avoid doing them in a big patch like this. If things needs to be reverted, as this patch was, such a formatting change should not need to be reverted.

This can also cause unnecessary work for downstream forks in case of merge conflicts (the first patch, the revert, the second patch, etc).

https://github.com/llvm/llvm-project/pull/73472


More information about the lldb-commits mailing list