[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class (second try). (PR #73472)

Alex Langford via lldb-commits lldb-commits at lists.llvm.org
Mon Nov 27 09:51:26 PST 2023


================
@@ -302,6 +303,256 @@ bool CompilerType::IsBeingDefined() const {
   return false;
 }
 
+bool CompilerType::IsSmartPtrType() const {
+  // These regular expressions cover shared, unique and weak pointers both from
+  // stdlibc++ and libc+++.
----------------
bulbazord wrote:

If it covers both, I would suggest changing the names of the variables to not have the word "libcxx" in them. Comments can get out of date or otherwise be misleading, this one feels confusing to read through. 

https://github.com/llvm/llvm-project/pull/73472


More information about the lldb-commits mailing list