[Lldb-commits] [lldb] Add new API in SBTarget for loading core from SBFile (PR #71769)

[Greg Clayton via lldb-commits]

================
@@ -184,6 +184,8 @@ class LLDB_API SBTarget {
 
   SBProcess LoadCore(const char *core_file);
   SBProcess LoadCore(const char *core_file, lldb::SBError &error);
+  SBProcess LoadCore(SBFile &file);
----------------
clayborg wrote:

Just add the error to your function call:
```
SBProcess LoadCore(SBFile &file, lldb::SBError &error);
```
The first `SBProcess LoadCore(const char *core_file);` should be marked as deprecated since we want people to use `SBProcess LoadCore(const char *core_file, lldb::SBError &error);` so they get error information back. In our public API we never remove an older API, and that is why `SBProcess LoadCore(const char *core_file);` is still there.

https://github.com/llvm/llvm-project/pull/71769