[Lldb-commits] [lldb] fd5206c - Revert "[lldb][test] Only add -m(64|32) for GCC on non Arm/AArch64 platforms"

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Fri Nov 10 05:17:34 PST 2023


Author: David Spickett
Date: 2023-11-10T13:17:01Z
New Revision: fd5206cc55c820598d5145d799b18d66cc193356

URL: https://github.com/llvm/llvm-project/commit/fd5206cc55c820598d5145d799b18d66cc193356
DIFF: https://github.com/llvm/llvm-project/commit/fd5206cc55c820598d5145d799b18d66cc193356.diff

LOG: Revert "[lldb][test] Only add -m(64|32) for GCC on non Arm/AArch64 platforms"

This reverts commit 7c3603e1c162382b5c038b99e482e0689e1505aa.

Turns out when you ask for "clang" it also uses the GCC Builder class,
so I need to update some tests.

Added: 
    

Modified: 
    lldb/test/Shell/helper/build.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/Shell/helper/build.py b/lldb/test/Shell/helper/build.py
index 561d9ba2363c7ae..2a04967c89bc305 100755
--- a/lldb/test/Shell/helper/build.py
+++ b/lldb/test/Shell/helper/build.py
@@ -747,10 +747,7 @@ def _get_compilation_command(self, source, obj):
         args = []
 
         args.append(self.compiler)
-
-        uname = platform.uname().machine.lower()
-        if not "arm" in uname and not "aarch64" in uname:
-            args.append("-m" + self.arch)
+        args.append("-m" + self.arch)
 
         args.append("-g")
         if self.opt == "none":
@@ -787,11 +784,7 @@ def _get_compilation_command(self, source, obj):
     def _get_link_command(self):
         args = []
         args.append(self.compiler)
-
-        uname = platform.uname().machine.lower()
-        if not "arm" in uname and not "aarch64" in uname:
-            args.append("-m" + self.arch)
-
+        args.append("-m" + self.arch)
         if self.nodefaultlib:
             args.append("-nostdlib")
             args.append("-static")


        


More information about the lldb-commits mailing list