[Lldb-commits] [lldb] [LLDB] Ensure the data of apple accelerator tables is kept around (PR #71828)

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Thu Nov 9 17:25:14 PST 2023


================
@@ -57,7 +57,9 @@ std::unique_ptr<AppleDWARFIndex> AppleDWARFIndex::Create(
     return std::make_unique<AppleDWARFIndex>(
----------------
clayborg wrote:

DataExtractor objects don't always have shared buffers. I am guessing in this case it does have them, but you might throw in a `lldbassert(...)` just in case to make sure this doesn't regress in the future.  Maybe something like:
```
lldbassert(apple_names.GetSharedDataBuffer());
lldbassert(apple_namespaces.GetSharedDataBuffer());
lldbassert(apple_types.GetSharedDataBuffer());
lldbassert(apple_objc.GetSharedDataBuffer());
```

https://github.com/llvm/llvm-project/pull/71828


More information about the lldb-commits mailing list