[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

[via lldb-commits]

=?utf-8?q?José?= L. Junior <josejunior at 10xengineers.ai>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/69422 at github.com>


taalhaataahir0102 wrote:

Hi David!
`ninja check-lldb` is failing for us. We've re-compiled the latest llvm project (without adding our implementation) but that one is also giving us the same error:
![image](https://github.com/llvm/llvm-project/assets/77788288/7a53677f-2438-4bb6-b4fa-10d6680de054)

```
Testing Time: 88.62s

Total Discovered Tests: 2888
  Skipped          :    1 (0.03%)
  Unsupported      :  491 (17.00%)
  Passed           : 1674 (57.96%)
  Expectedly Failed:   19 (0.66%)
  Unresolved       :  656 (22.71%)
  Failed           :   47 (1.63%)

2 warning(s) in tests
FAILED: tools/lldb/test/CMakeFiles/check-lldb /home/talha/llvm-latest/llvm-project-main/build/tools/lldb/test/CMakeFiles/check-lldb 
cd /home/talha/llvm-latest/llvm-project-main/build/tools/lldb/test && /usr/bin/python3.10 /home/talha/llvm-latest/llvm-project-main/build/./bin/llvm-lit -sv /home/talha/llvm-latest/llvm-project-main/build/tools/lldb/test
ninja: build stopped: subcommand failed.
```

We've used the following command for building lldb:
`cmake -G Ninja -DLLVM_ENABLE_PROJECTS="lldb;clang" -DLLVM_USE_LINKER=lld -DLLVM_BUILD_TESTS=true -DCMAKE_BUILD_TYPE=Release /home/talha/llvm-latest/llvm-project-main/llvm`

Can you please confirm if there's something wrong in our build. Also I've the complete log of ninja `check-lldb` but it's pretty long. Do you need it to figure out the issue?

Plus there's one more thing we are not sure of as we are new to github. There have been some updates in a file we've changed in our draft (`source/Commands/CommandObjectTarget.cpp`). So do we need a fresh build and add our implementation there before the final review? As the draft also says that

> This branch has conflicts that must be resolved

> Conflicting files
> lldb/source/Commands/CommandObjectTarget.cpp

https://github.com/llvm/llvm-project/pull/69422